-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding route action field in the ExternalProcessing proto #33582
Adding route action field in the ExternalProcessing proto #33582
Conversation
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, Yanjun!
I just copied my comment in #33568 to here, as I guess this is the version to be merged.
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…_route_cache_proto Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…e doc. Remove that ref Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Defer to @mattklein123 for final API review and merge.
/assign @htuch |
Kind Ping! |
…#33582) Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
This PR is a follow up change for: #33582. It is to support RouteCacheAction to force clearing the route cache in ext_proc filter even side stream server does not send the clear_route_cache in the response. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]