Adding route action field in the ExternalProcessing proto #33582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
rshriram
approved these changes
Apr 17, 2024
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…_route_cache_proto Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…e doc. Remove that ref Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
tyxia
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM Thanks!
Defer to @mattklein123 for final API review and merge.
|
/assign @htuch |
|
Kind Ping! |
mattklein123
approved these changes
Apr 25, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…#33582) Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
htuch
pushed a commit
that referenced
this pull request
May 9, 2024
This PR is a follow up change for: #33582. It is to support RouteCacheAction to force clearing the route cache in ext_proc filter even side stream server does not send the clear_route_cache in the response. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]