Envoy Mobile: making exception-free build the default

.github/config.yml

@@ -48,11 +48,6 @@ checks:
     required: true
     on-run:
     - mobile-cc
-  mobile-compile-time-options:
-    name: Mobile/Compile time options
-    on-run:
-    - mobile-compile-time-cc
-    - mobile-compile-time-options
   mobile-coverage:
     name: Mobile/Coverage
     required: true
@@ -217,32 +212,6 @@ run:
     - test/integration/*
     - test/mocks/**/*
     - test/test_common/**/*
-  mobile-compile-time-cc:
-    paths:
-    - .bazelrc
-    - .bazelversion
-    - .github/config.yml
-    - api/**/*
-    - bazel/external/quiche.BUILD
-    - bazel/repository_locations.bzl
-    - envoy/**/*
-    - mobile/.bazelrc
-    - mobile/**/*
-    - source/**/*
-    - test/config/**/*
-    - test/integration/*
-    - test/mocks/**/*
-    - test/test_common/**/*
-  mobile-compile-time-options:
-    paths:
-    - .bazelrc
-    - .bazelversion
-    - .github/config.yml
-    - bazel/external/quiche.BUILD
-    - bazel/repository_locations.bzl
-    - mobile/.bazelrc
-    - mobile/**/*
-    - tools/code_format/check_format.py
   mobile-coverage:
     paths:
     - .bazelrc

bazel/envoy_build_system.bzl

@@ -35,6 +35,7 @@ load(
     _envoy_select_boringssl = "envoy_select_boringssl",
     _envoy_select_disable_exceptions = "envoy_select_disable_exceptions",
     _envoy_select_disable_logging = "envoy_select_disable_logging",
+    _envoy_select_enable_exceptions = "envoy_select_enable_exceptions",
     _envoy_select_enable_http3 = "envoy_select_enable_http3",
     _envoy_select_enable_http_datagrams = "envoy_select_enable_http_datagrams",
     _envoy_select_enable_yaml = "envoy_select_enable_yaml",
@@ -239,6 +240,7 @@ envoy_select_google_grpc = _envoy_select_google_grpc
 envoy_select_enable_http3 = _envoy_select_enable_http3
 envoy_select_enable_yaml = _envoy_select_enable_yaml
 envoy_select_disable_exceptions = _envoy_select_disable_exceptions
+envoy_select_enable_exceptions = _envoy_select_enable_exceptions
 envoy_select_hot_restart = _envoy_select_hot_restart
 envoy_select_enable_http_datagrams = _envoy_select_enable_http_datagrams
 envoy_select_signal_trace = _envoy_select_signal_trace

bazel/envoy_select.bzl

@@ -87,6 +87,13 @@ def envoy_select_disable_exceptions(xs, repository = ""):
         "//conditions:default": [],
     })
 
+# Selects the given values if exceptions are enabled in the current build.
+def envoy_select_enable_exceptions(xs, repository = ""):
+    return select({
+        repository + "//bazel:disable_exceptions": [],
+        "//conditions:default": xs,
+    })
+
 # Selects the given values if HTTP datagram support is enabled in the current build.
 def envoy_select_enable_http_datagrams(xs, repository = ""):
     return select({

contrib/generic_proxy/filters/network/test/BUILD

@@ -103,6 +103,7 @@ envoy_cc_test(
         "//source/extensions/transport_sockets/raw_buffer:config",
         "//test/common/upstream:utility_lib",
         "//test/integration:base_integration_test_lib",
+        "//test/integration:common_extensions_lib",
         "//test/mocks/server:factory_context_mocks",
         "//test/mocks/upstream:cluster_info_mocks",
         "//test/test_common:registry_lib",

mobile/.bazelrc

@@ -31,6 +31,8 @@ build --experimental_repository_downloader_retries=2
 build --define=google_grpc=disabled
 build --define=envoy_yaml=disabled
 build --define=envoy_full_protos=disabled
+build --define envoy_exceptions=disabled
+build: --copt=-fno-exceptions
 
 # We don't have a ton of Swift in Envoy Mobile, so always build with WMO
 # This also helps work around a bug in rules_swift: https://github.com/bazelbuild/rules_swift/issues/949
@@ -242,6 +244,7 @@ test:mobile-remote-ci-android --config=mobile-test-android
 build:mobile-remote-ci-cc --config=mobile-remote-ci
 test:mobile-remote-ci-cc --action_env=LD_LIBRARY_PATH
 
+# TODO(alyssar) remove in a follow-up PR
 build:mobile-remote-ci-cc-no-exceptions --config=mobile-remote-ci-cc
 build:mobile-remote-ci-cc-no-exceptions --define envoy_exceptions=disabled
 build:mobile-remote-ci-cc-no-exceptions --copt=-fno-exceptions

mobile/test/common/extensions/filters/http/platform_bridge/BUILD

@@ -36,7 +36,7 @@ envoy_extension_cc_test(
         "//library/common/api:external_api_lib",
         "//library/common/extensions/filters/http/platform_bridge:config",
         "//library/common/extensions/filters/http/platform_bridge:filter_cc_proto",
-        "@envoy//test/integration:http_integration_lib",
+        "@envoy//test/integration:http_integration_lib_light",
         "@envoy//test/mocks/server:factory_context_mocks",
         "@envoy//test/test_common:simulated_time_system_lib",
         "@envoy//test/test_common:utility_lib",

mobile/test/common/extensions/stat_sinks/metrics_service/BUILD

@@ -32,7 +32,7 @@ envoy_extension_cc_test(
         "//library/common/extensions/stat_sinks/metrics_service:config",
         "//library/common/extensions/stat_sinks/metrics_service:config_proto_cc_proto",
         "//library/common/extensions/stat_sinks/metrics_service:service_cc_proto",
-        "@envoy//test/integration:http_integration_lib",
+        "@envoy//test/integration:http_integration_lib_light",
         "@envoy//test/mocks/grpc:grpc_mocks",
         "@envoy//test/mocks/local_info:local_info_mocks",
         "@envoy//test/mocks/thread_local:thread_local_mocks",

mobile/test/common/integration/BUILD

@@ -53,7 +53,7 @@ envoy_cc_test_library(
         "//library/common/http:header_utility_lib",
         "//library/common/types:c_types_lib",
         "@envoy//test/common/http:common_lib",
-        "@envoy//test/integration:http_integration_lib",
+        "@envoy//test/integration:http_integration_lib_light",
         "@envoy//test/test_common:utility_lib",
     ],
 )

source/common/listener_manager/filter_chain_manager_impl.cc

@@ -138,7 +138,7 @@ void FilterChainManagerImpl::addFilterChains(
   for (const auto& filter_chain : filter_chain_span) {
     const auto& filter_chain_match = filter_chain->filter_chain_match();
     if (!filter_chain_match.address_suffix().empty() || filter_chain_match.has_suffix_len()) {
-      throw EnvoyException(fmt::format(
+      throwEnvoyExceptionOrPanic(fmt::format(
           "error adding listener '{}': filter chain '{}' contains "
           "unimplemented fields",
           absl::StrJoin(addresses_, ",", Network::AddressStrFormatter()), filter_chain->name()));
@@ -157,7 +157,7 @@ void FilterChainManagerImpl::addFilterChains(
                          MessageUtil::getJsonStringFromMessageOrError(filter_chain_match, false));
 #endif
 
-        throw EnvoyException(error_msg);
+        throwEnvoyExceptionOrPanic(error_msg);
       }
       filter_chains.insert({filter_chain_match, filter_chain->name()});
     }
@@ -175,14 +175,14 @@ void FilterChainManagerImpl::addFilterChains(
     // If using the matcher, require usage of "name" field and skip building the index.
     if (filter_chain_matcher) {
       if (filter_chain->name().empty()) {
-        throw EnvoyException(fmt::format(
+        throwEnvoyExceptionOrPanic(fmt::format(
             "error adding listener '{}': \"name\" field is required when using a listener matcher",
             absl::StrJoin(addresses_, ",", Network::AddressStrFormatter())));
       }
       auto [_, inserted] =
           filter_chains_by_name.try_emplace(filter_chain->name(), filter_chain_impl);
       if (!inserted) {
-        throw EnvoyException(fmt::format(
+        throwEnvoyExceptionOrPanic(fmt::format(
             "error adding listener '{}': \"name\" field is duplicated with value '{}'",
             absl::StrJoin(addresses_, ",", Network::AddressStrFormatter()), filter_chain->name()));
       }
@@ -213,7 +213,7 @@ void FilterChainManagerImpl::addFilterChains(
       // Reject partial wildcards, we don't match on them.
       for (const auto& server_name : filter_chain_match.server_names()) {
         if (absl::StrContains(server_name, '*') && !isWildcardServerName(server_name)) {
-          throw EnvoyException(
+          throwEnvoyExceptionOrPanic(
               fmt::format("error adding listener '{}': partial wildcards are not supported in "
                           "\"server_names\"",
                           absl::StrJoin(addresses_, ",", Network::AddressStrFormatter())));
@@ -442,7 +442,7 @@ void FilterChainManagerImpl::addFilterChainForSourcePorts(
     // If we got here and found already configured branch, then it means that this FilterChainMatch
     // is a duplicate, and that there is some overlap in the repeated fields with already processed
     // FilterChainMatches.
-    throw EnvoyException(
+    throwEnvoyExceptionOrPanic(
         fmt::format("error adding listener '{}': multiple filter chains with "
                     "overlapping matching rules are defined",
                     absl::StrJoin(addresses_, ",", Network::AddressStrFormatter())));

source/common/listener_manager/lds_api.cc

@@ -110,9 +110,7 @@ LdsApiImpl::onConfigUpdate(const std::vector<Config::DecodedResourceRef>& added_
       }
     }
     END_TRY
-    catch (const EnvoyException& e) {
-      onError(e.what());
-    }
+    CATCH(EnvoyException & e, { onError(e.what()); })
   }
   listener_manager_.endListenerUpdate(std::move(failure_state));