-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add %UPSTREAM_CLUSTER_RAW% formatter #35265
Add %UPSTREAM_CLUSTER_RAW% formatter #35265
Conversation
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
/assign-from @envoyproxy/envoy-maintainers |
@envoyproxy/envoy-maintainers assignee is @htuch |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
/retest |
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution. Please merge main and resolve the conflict. Then ping me to merge this PR. Thanks again. :)
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@wbpcode conflicts resolved thanks! Should be good to merged after tests complete |
LGTM |
The %UPSTREAM_CLUSTER% formatter is affected by alt_stat_name, but there are times where a custom stat name may have special delimeters meant to help with stat tag regex parsing but those delimeters shouldn't show up in access logs. In these cases, %RAW_UPSTREAM_CLUSTER% could be used. Commit Message: Add %RAW_UPSTREAM_CLUSTER% access log formatter Additional Description: Risk Level: no Testing: unit Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
…ttp1_reverse_bridge_handle_empty_response * upstream/main: tcp conn pool: honor connection_pool_per_downstream_connection (envoyproxy#34763) runtime: deprecating avoid_zombie_streams (envoyproxy#35376) tracing: xray annotation documentation and CODEOWNER (envoyproxy#35257) overload manager: removing exceptions (envoyproxy#35347) runtime: remove runtime flag envoy.reloadable_features.abort_filter_chain_on_stream_reset (envoyproxy#35405) build(deps): bump nginx from `67682bd` to `6af79ae` in /examples/local_ratelimit in the examples-local-ratelimit group (envoyproxy#35401) build(deps): bump postgres from `0aafd2a` to `7963e57` in /examples/shared/postgres (envoyproxy#35400) build(deps): bump node from `426d993` to `2fb92fe` in /examples/shared/node (envoyproxy#35399) build(deps): bump mysql from 9.0.0 to 9.0.1 in /examples/mysql (envoyproxy#35402) build(deps): bump framer-motion from 11.3.8 to 11.3.12 in /examples/single-page-app/ui (envoyproxy#35398) build(deps): bump golang from `6c27802` to `af9b40f` in /examples/shared/golang (envoyproxy#35395) build(deps): bump redis from `fb534a3` to `5a82749` in /examples/redis (envoyproxy#35397) Add %UPSTREAM_CLUSTER_RAW% formatter (envoyproxy#35265) Remove runtime flag envoy_reloadable_features_send_header_raw_value (envoyproxy#35388) router: removing a few exceptions (envoyproxy#35346) Quiche roll 20240717144914 (envoyproxy#35241) ext_proc: flow control in observability mode (envoyproxy#35298) tls: remove runtime guard `ssl_transport_failure_reason_format` (envoyproxy#35389)
The %UPSTREAM_CLUSTER% formatter is affected by alt_stat_name, but there are times where a custom stat name may have special delimeters meant to help with stat tag regex parsing but those delimeters shouldn't show up in access logs. In these cases, %RAW_UPSTREAM_CLUSTER% could be used. Commit Message: Add %RAW_UPSTREAM_CLUSTER% access log formatter Additional Description: Risk Level: no Testing: unit Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
The %UPSTREAM_CLUSTER% formatter is affected by alt_stat_name, but there are times where a custom stat name may have special delimeters meant to help with stat tag regex parsing but those delimeters shouldn't show up in access logs. In these cases, %RAW_UPSTREAM_CLUSTER% could be used. Commit Message: Add %RAW_UPSTREAM_CLUSTER% access log formatter Additional Description: Risk Level: no Testing: unit Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Fixes commit #PR or SHA] [Optional Deprecated:] [Optional [API Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):] --------- Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> Signed-off-by: asingh-g <abhisinghx@google.com>
The %UPSTREAM_CLUSTER% formatter is affected by alt_stat_name, but there are times where a custom stat name may have special delimeters meant to help with stat tag regex parsing but those delimeters shouldn't show up in access logs. In these cases, %RAW_UPSTREAM_CLUSTER% could be used.
Commit Message: Add %RAW_UPSTREAM_CLUSTER% access log formatter
Additional Description:
Risk Level: no
Testing: unit
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]