-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext_proc: flow control in observability mode #35298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
alyssawilk
reviewed
Jul 23, 2024
Signed-off-by: tyxia <tyxia@google.com>
alyssawilk
approved these changes
Jul 23, 2024
alyssawilk
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Mind updating PR descripton with the template (low risk, behind existing runtime guard etc)?
Thanks all for review! |
hq6
added a commit
to hq6/envoy
that referenced
this pull request
Jul 24, 2024
…ttp1_reverse_bridge_handle_empty_response * upstream/main: tcp conn pool: honor connection_pool_per_downstream_connection (envoyproxy#34763) runtime: deprecating avoid_zombie_streams (envoyproxy#35376) tracing: xray annotation documentation and CODEOWNER (envoyproxy#35257) overload manager: removing exceptions (envoyproxy#35347) runtime: remove runtime flag envoy.reloadable_features.abort_filter_chain_on_stream_reset (envoyproxy#35405) build(deps): bump nginx from `67682bd` to `6af79ae` in /examples/local_ratelimit in the examples-local-ratelimit group (envoyproxy#35401) build(deps): bump postgres from `0aafd2a` to `7963e57` in /examples/shared/postgres (envoyproxy#35400) build(deps): bump node from `426d993` to `2fb92fe` in /examples/shared/node (envoyproxy#35399) build(deps): bump mysql from 9.0.0 to 9.0.1 in /examples/mysql (envoyproxy#35402) build(deps): bump framer-motion from 11.3.8 to 11.3.12 in /examples/single-page-app/ui (envoyproxy#35398) build(deps): bump golang from `6c27802` to `af9b40f` in /examples/shared/golang (envoyproxy#35395) build(deps): bump redis from `fb534a3` to `5a82749` in /examples/redis (envoyproxy#35397) Add %UPSTREAM_CLUSTER_RAW% formatter (envoyproxy#35265) Remove runtime flag envoy_reloadable_features_send_header_raw_value (envoyproxy#35388) router: removing a few exceptions (envoyproxy#35346) Quiche roll 20240717144914 (envoyproxy#35241) ext_proc: flow control in observability mode (envoyproxy#35298) tls: remove runtime guard `ssl_transport_failure_reason_format` (envoyproxy#35389)
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
Commit Message: This PR is split from envoyproxy#35077. The change is specifically needed for ext_proc's observability mode where the stream is deferred closed upon filter destruction (i.e., stream outlives the filter object) Risk Level: Low, existing runtime guard and observability mode only Testing: e2e test and load test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Commit Message: This PR is split from envoyproxy#35077. The change is specifically needed for ext_proc's observability mode where the stream is deferred closed upon filter destruction (i.e., stream outlives the filter object) Risk Level: Low, existing runtime guard and observability mode only Testing: e2e test and load test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: This PR is split from #35077. The change is specifically needed for ext_proc's observability mode where the stream is deferred closed upon filter destruction (i.e., stream outlives the filter object)
Risk Level: Low, existing runtime guard and observability mode only
Testing: e2e test and load test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A