Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize object apply update logic. #1046

Merged
merged 1 commit into from
Feb 16, 2023
Merged

optimize object apply update logic. #1046

merged 1 commit into from
Feb 16, 2023

Conversation

qicz
Copy link
Member

@qicz qicz commented Feb 15, 2023

omit fix about #1041

Signed-off-by: qicz <qiczzhu@gmail.com>
@qicz qicz requested a review from a team as a code owner February 15, 2023 07:29
@qicz qicz changed the title optimize object apply logic. optimize object apply update logic. Feb 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1046 (e368675) into main (7419603) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
- Coverage   64.61%   64.59%   -0.02%     
==========================================
  Files          67       67              
  Lines        8726     8728       +2     
==========================================
  Hits         5638     5638              
- Misses       2717     2719       +2     
  Partials      371      371              
Impacted Files Coverage Δ
internal/status/status.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qicz qicz closed this Feb 15, 2023
@qicz qicz reopened this Feb 15, 2023
@arkodg
Copy link
Contributor

arkodg commented Feb 15, 2023

hey @qicz can you elaborate on the commit message, was the issue not fixed with #1042 ?

@qicz
Copy link
Member Author

qicz commented Feb 16, 2023

hey @qicz can you elaborate on the commit message, was the issue not fixed with #1042 ?

#1042 just fix the infra for updating. this pr fixes the HTTRoute, GRPCRoute, etc updates.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 9785b41 into envoyproxy:main Feb 16, 2023
@qicz qicz deleted the fix-apply branch February 16, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants