chore: GHA to request reviews from gateway-reviewers #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GH recommends using CODEOWNERS to automatically request reviewers on PRs. https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners. However the teams mentioned within the `CODEOWNERS` file must have WRITE access. Since this is not the case for `envoyproxy/gateway-reviewers` who have `triage` access today, this PR adds a Github Action that adds envoyproxy/gateway-reviewers as reviewers using the GH CLI whenever a PR is opened Adapted from https://stackoverflow.com/questions/66557514/how-to-automatically-request-a-review-from-someone-using-github-actions Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 62.40% 62.53% +0.12%
==========================================
Files 78 78
Lines 10953 10953
==========================================
+ Hits 6835 6849 +14
+ Misses 3667 3655 -12
+ Partials 451 449 -2 |
|
this is not going to work since the GH TOKEN for forks dont have enough permissions to modify the PR |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
|
looks like this can only be tested when this GHA lands on |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
AliceProxy
approved these changes
May 2, 2023
qicz
approved these changes
May 3, 2023
Xunzhuo
pushed a commit
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners. However the teams mentioned within the
CODEOWNERSfile must have WRITE access. Since this is not the case forenvoyproxy/gateway-reviewerswho havetriageaccess today, this PR adds a Github Action that adds envoyproxy/gateway-reviewers as reviewers using the GH CLI whenever a PR is openedAdapted from https://stackoverflow.com/questions/66557514/how-to-automatically-request-a-review-from-someone-using-github-actions