Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: GHA to request reviews from gateway-reviewers (#1388)" #1390

Merged
merged 1 commit into from
May 3, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented May 3, 2023

This reverts commit 29bcb78.

Reverts #1388

…oxy#1388)"

This reverts commit 29bcb78.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 3, 2023 03:57
@arkodg
Copy link
Contributor Author

arkodg commented May 3, 2023

reason to revert this the workflow is failing https://github.com/envoyproxy/gateway/actions/runs/4868142655/jobs/8681356126?pr=1390
because the GH_TOKEN has a max read access

@qicz
Copy link
Member

qicz commented May 3, 2023

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1390 (b243852) into main (29bcb78) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   62.36%   62.32%   -0.05%     
==========================================
  Files          78       78              
  Lines       10959    10959              
==========================================
- Hits         6835     6830       -5     
- Misses       3673     3677       +4     
- Partials      451      452       +1     

see 2 files with indirect coverage changes

@Xunzhuo Xunzhuo merged commit bd43fbe into envoyproxy:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants