Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add user/tls-cert-manager.md #1461

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

tommie
Copy link
Contributor

@tommie tommie commented May 29, 2023

This shows how to set up cert-manager to work with Envoy Gateway.

What this PR does / why we need it:
cert-manager is useful both for self-signed and Let's Encrypt.

Which issue(s) this PR fixes:
Fixes #954

@tommie tommie requested a review from a team as a code owner May 29, 2023 19:22
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #1461 (b3e6800) into main (80db459) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
+ Coverage   61.43%   61.50%   +0.06%     
==========================================
  Files          79       79              
  Lines       11439    11459      +20     
==========================================
+ Hits         7028     7048      +20     
- Misses       3950     3952       +2     
+ Partials      461      459       -2     

see 11 files with indirect coverage changes

@tommie
Copy link
Contributor Author

tommie commented May 29, 2023

This is now also touching on #953, and it should probably be made more standalone. Setting up ExternalDNS was very simple (on the Gateway API side,) so not sure how useful that guide would actually be on its own. (The config complexitiy is in which out of the tens of DNS providers you use.)

@qicz
Copy link
Member

qicz commented May 30, 2023

@tommie hey, pls fix DCO

This shows how to set up cert-manager to work with Envoy Gateway.

Signed-off-by: Tommie Gannert <tommie@gannert.se>
arkodg
arkodg previously approved these changes May 30, 2023
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for also adding all the "under the hood" explanations !

qicz
qicz previously approved these changes May 30, 2023
Signed-off-by: Tommie Gannert <tommie@gannert.se>
@tommie tommie dismissed stale reviews from qicz and arkodg via b3e6800 May 31, 2023 08:05
@tommie
Copy link
Contributor Author

tommie commented May 31, 2023

Fixed some last-minute grammar issuer, and also realized I hadn't added the ACME order,challenge sample output.

@arkodg arkodg merged commit 22bd06b into envoyproxy:main May 31, 2023
18 checks passed
@tommie tommie deleted the tls-cert-manager branch June 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for using Cert Manager to manage Gateway Certs
3 participants