Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce RL E2E sleep to 3s #1466

Merged
merged 1 commit into from
May 31, 2023
Merged

Reduce RL E2E sleep to 3s #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/tests/ratelimit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var RateLimitTest = suite.ConformanceTest{

// TODO: find a better to make sure ratelimit load new configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we delete/update this lines now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should keep that line until we delete the sleep with something more reliable, like some xds confirmation in route status

Copy link
Contributor

@shawnh2 shawnh2 May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on delete this two TODO lines right now, can refer to #1469

// just wait a bit more time for now
time.Sleep(30 * time.Second)
time.Sleep(3 * time.Second)

// TODO: should just send exactly 4 requests, and expect 429
http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, suite.TimeoutConfig, gwAddr, http.ExpectedResponse{
Expand Down