DeepCopy resources that require status updates

[arkodg]

• Was seeing constant churn between provider runner publishing resources and gateway-api runner receiving them.

• Tried to debug it by printing the o/p of cmp.Diff between current and previous values

diff --git a/internal/gatewayapi/runner/runner.go b/internal/gatewayapi/runner/runner.go
index 050394ba..50d09f6f 100644
--- a/internal/gatewayapi/runner/runner.go
+++ b/internal/gatewayapi/runner/runner.go
@@ -8,6 +8,7 @@ package runner
 import (
        "context"

+       "github.com/google/go-cmp/cmp"
        "k8s.io/apimachinery/pkg/runtime/schema"
        "sigs.k8s.io/gateway-api/apis/v1beta1"
        "sigs.k8s.io/yaml"
@@ -49,6 +50,7 @@ func (r *Runner) Start(ctx context.Context) error {
 }

 func (r *Runner) subscribeAndTranslate(ctx context.Context) {
+       prev := &gatewayapi.Resources{}
        message.HandleSubscription(r.ProviderResources.GatewayAPIResources.Subscribe(ctx),
                func(update message.Update[string, *gatewayapi.Resources]) {
                        val := update.Value
@@ -56,6 +58,9 @@ func (r *Runner) subscribeAndTranslate(ctx context.Context) {
                        if update.Delete || val == nil {
                                return
                        }
+                       diff := cmp.Diff(prev, val)
+                       r.Logger.WithValues("output", "diff").Info(diff)
+                       prev = val.DeepCopy()

                        // Translate and publish IRs.
                        t := &gatewayapi.Translator{

Here's the o/p and its empty

2023-07-27T23:55:29.795Z	INFO	gateway-api	runner/runner.go:62		{"runner": "gateway-api", "output": "diff"}

• Using a DeepCopy for resources that were updating the Status subresource seems to have solved the issue, which implies that watchable doesnt like clients to mutate the value, even though they are meant to be a DeepCopy

Fixes: #1715

[arkodg]

cc @LukeShu

[codecov]

Codecov Report

Merging #1723 (93cae96) into main (ea18f8f) will increase coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
+ Coverage   64.77%   64.85%   +0.07%     
==========================================
  Files          83       83              
  Lines       11925    11928       +3     
==========================================
+ Hits         7725     7736      +11     
+ Misses       3715     3710       -5     
+ Partials      485      482       -3     

Files Changed	Coverage Δ
internal/gatewayapi/runner/runner.go	25.49% <0.00%> (-0.51%)	⬇️
internal/xds/server/runner/runner.go	29.80% <0.00%> (-0.29%)	⬇️
internal/gatewayapi/envoypatchpolicy.go	69.51% <100.00%> (ø)
internal/gatewayapi/route.go	88.36% <100.00%> (ø)

... and 2 files with indirect coverage changes

[zirain]

ditto

[zirain]

this should be a debug log