Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable ratelimit server start without initial config and add readiness probe for it #1815

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 22, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1792

…s for envoy-ratelimit pod

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner August 22, 2023 03:15
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1815 (7d7c39d) into main (4285f4e) will increase coverage by 0.14%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1815      +/-   ##
==========================================
+ Coverage   65.11%   65.25%   +0.14%     
==========================================
  Files          86       86              
  Lines       12316    12335      +19     
==========================================
+ Hits         8019     8049      +30     
+ Misses       3782     3773       -9     
+ Partials      515      513       -2     
Files Changed Coverage Δ
...al/infrastructure/kubernetes/ratelimit/resource.go 96.53% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, kflynn, qicz and LanceEa and removed request for a team August 24, 2023 14:55
Copy link
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit 3999cdd into envoyproxy:main Aug 24, 2023
18 checks passed
@shawnh2 shawnh2 deleted the add-rl-readiness-probe branch August 25, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod envoy-ratelimit stucks in Terminating for a really long time when delete it
3 participants