Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs and fix for ref grant in service import case #1852

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

tanujd11
Copy link
Member

What type of PR is this?

What this PR does / why we need it:
Adds docs for the Multicluster services service import.
A fix is added for service import working with reference grant.
Which issue(s) this PR fixes:

Fixes #

Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
@tanujd11 tanujd11 requested a review from a team as a code owner August 30, 2023 21:14
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1852 (3d28e04) into main (f30dc6a) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
+ Coverage   65.29%   65.39%   +0.09%     
==========================================
  Files          86       86              
  Lines       12526    12526              
==========================================
+ Hits         8179     8191      +12     
+ Misses       3828     3818      -10     
+ Partials      519      517       -2     
Files Changed Coverage Δ
internal/provider/kubernetes/routes.go 43.72% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a demo and also the fix : ) It worked for me.

@zirain
Copy link
Contributor

zirain commented Sep 5, 2023

/retest

@Xunzhuo Xunzhuo requested a review from zirain September 5, 2023 07:59
@zirain
Copy link
Contributor

zirain commented Sep 5, 2023

/retest

seems like a github issue

@zirain
Copy link
Contributor

zirain commented Sep 5, 2023

/retest

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 5, 2023

@zirain just a code patch

@Xunzhuo Xunzhuo requested review from a team, zhaohuabing, LanceEa and chauhanshubham and removed request for a team September 5, 2023 11:26
@zirain zirain merged commit 1fab508 into envoyproxy:main Sep 5, 2023
19 of 20 checks passed
Xunzhuo added a commit to Xunzhuo/gateway that referenced this pull request Sep 6, 2023
Signed-off-by: bitliu <bitliu@tencent.com>
zirain pushed a commit that referenced this pull request Sep 6, 2023
* 🐛 Fix: follow-up of #1852

Signed-off-by: bitliu <bitliu@tencent.com>

* 🎉 Update

Signed-off-by: bitliu <bitliu@tencent.com>

---------

Signed-off-by: bitliu <bitliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants