🐛 Fix: follow-up of #1852 #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bitliu <bitliu@tencent.com>
Xunzhuo
requested review from
a team,
kflynn,
zhaohuabing and
qicz
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
- Coverage 65.35% 65.31% -0.04%
==========================================
Files 86 86
Lines 12526 12526
==========================================
- Hits 8186 8181 -5
- Misses 3823 3826 +3
- Partials 517 519 +2 |
zirain
previously approved these changes
Sep 6, 2023
zhaohuabing
reviewed
Sep 6, 2023
zhaohuabing
approved these changes
Sep 6, 2023
zirain
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: