New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource unmarshalling in cache_dump admin API #93

Closed

LisaLudique opened this issue May 26, 2020 · 0 comments · Fixed by #99

Assignees

Milestone

Contributor

LisaLudique commented May 26, 2020

The resources in the DiscoveryResponse are still in their marshalled any.Any form when fetched with the cache_dump API (https://github.com/envoyproxy/xds-relay/pull/74/files#r426102814). The cache_dump API should inspect the type_URL to unmarshal the Any variable into the correct resource to make it more readable: https://envoyproxy.slack.com/archives/CTULFMN91/p1590087624055200?thread_ts=1590087384.054900&cid=CTULFMN91.

jessicayuen added this to the MVP - v1.0.0 milestone

LisaLudique self-assigned this

LisaLudique mentioned this issue

Unmarshal v2 resources in cache_dump #99

Merged

LisaLudique linked a pull request

that will close this issue

Unmarshal v2 resources in cache_dump #99

Merged

LisaLudique closed this as completed in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment