Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phy and group adresses #3

Closed
ghost opened this issue Aug 21, 2017 · 3 comments
Closed

Phy and group adresses #3

ghost opened this issue Aug 21, 2017 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Aug 21, 2017

Hi. I have checked your code and example - great working ! Thank you.
One small thing: Please use the standard syntax fpr physical adresses with pots like 0.0.1 in your webpage. Group adresses with slashes like 0/0/1. It makes things more clear :-)

For finalization it would be great to seperate the webserver implementation and the KNX finctionality.

best regards, Peter

@envy
Copy link
Owner

envy commented Aug 22, 2017

Hi,

One small thing: Please use the standard syntax fpr physical adresses with pots like 0.0.1 in your webpage. Group adresses with slashes like 0/0/1. It makes things more clear :-)

Will change this with one of the next commits.

For finalization it would be great to seperate the webserver implementation and the KNX finctionality.

I don't know how I want to handle this, yet. My plan was to be able to flash the same firmware onto multiple devices and then configure the GAs in some other way so that they are not hardcoded.
My first idea was an application running on a PC sending special UDP packets that would configure the device, but this is too complex. So self-contained configuration via webserver was easiest. I'll probably make it disableable during compile time with a define or something.
Maybe one day I can trick the ETS into programming ESPs ;D

@envy envy self-assigned this Aug 22, 2017
@ghost
Copy link
Author

ghost commented Aug 22, 2017

Hi envy !
To ctrl and setup the config via webpage is a good way - only to have the webserver implementation and the KNX object in the same files makes it not easy to use it in other projects - i.e if there already a webserver is running.
my 5ct :-)
In my case I #undefine it - no problem.
regards, Peter

@envy
Copy link
Owner

envy commented Nov 12, 2017

I changed the notation of physical address in the webserver to dots. I also added the possibility to specify own webserver object, so that the knx system reuses the same webserver as other code. However, I need to add the possibility to specify a prefix for the knx endpoints as to not clash with other endpoints.

@envy envy closed this as completed Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant