Check at least one server response

[araab]

If the connection to the server fails the responses array in the
ResponseCollection class is empty and the success function returns true.
Perhaps the default value of $success should be false and set to true if
at least one response was successful.

    public function success($first = false)
    {
        $success = false;
        if ($first === true) {
            // Sort them by timestamp, pop the first one and return pass/fail
            usort($this->responses, function($r1, $r2) {
                return $r1->getMt() > $r2->getMt();
            });
            $response = $this->responses[0];
            return $response->success();
        } else {
            foreach ($this->responses as $response) {
                if ($response->success() === false) {
                    return false;
                } else {
                    $success = true;
                }
            }
        }
        return $success;
    }

[enygma]

Wouldn't that be correct? If it fails on success() it will return false. Otherwise the $success value starts out as false at the top there...

[araab]

The code above is a suggestion how to change it.

The current function sets $success to true as default. This is the current function:

    public function success($first = false)
    {
        $success = true;
        if ($first === true) {
            // Sort them by timestamp, pop the first one and return pass/fail
            usort($this->responses, function($r1, $r2) {
                return $r1->getMt() > $r2->getMt();
            });
            $response = $this->responses[0];
            return $response->success();
        } else {
            foreach ($this->responses as $response) {
                if ($response->success() === false) {
                    return false;
                }
            }
        }
        return $success;
    }

Here an example with the current function.

$v = new \Yubikey\Validate($apiKey, $clientId, array("localhost:8888"));
$result = $v->check($otp);
print_r($result);
var_export($result->success());

You get the following output:

Yubikey\ResponseCollection Object
(
    [responses:Yubikey\ResponseCollection:private] => Array
        (
        )

    [position:Yubikey\ResponseCollection:private] => 0
)
true

$result->success() returns true because the $responses array is
empty and if ($response->success() === false) is never reached.

[enygma]

Thanks for the suggestion - I've added it in 7a78243