Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue while minifying the opentip.js file #15

Closed
nowol opened this issue Oct 19, 2012 · 3 comments
Closed

Issue while minifying the opentip.js file #15

nowol opened this issue Oct 19, 2012 · 3 comments

Comments

@nowol
Copy link

nowol commented Oct 19, 2012

Hi,

I had an issue while trying to minify opentip.js using the Yui Compressor. I tracked it down with the help of the Yui Compressor maintainer to the use of the reserved keyword "char" in the dasherize method.

I was wondering if you could change the method dasherize from this:

Opentip::dasherize = (string) ->
  string.replace /([A-Z])/g, (_, char) -> "-#{char.toLowerCase()}"

To this:

Opentip::dasherize = (string) ->
  string.replace /([A-Z])/g, (_, character) -> "-#{character.toLowerCase()}"

Only "char" was renamed.

Thanks!

@enyo enyo closed this as completed in 2d39474 Oct 19, 2012
@enyo
Copy link
Owner

enyo commented Oct 19, 2012

Thanks @nowol !

@enyo
Copy link
Owner

enyo commented Oct 19, 2012

It'll be merged into the master branch and released as a version as soon as I implemented a few other things. So if you want to redownload it, please use the develop branch for now.

@nowol
Copy link
Author

nowol commented Oct 22, 2012

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants