Build without grackle fails

[pgrete]

I tried to build the DD branch without Grackle and followed the doc setting use_grackle = 0 in the top level SConstruct.
The build fails with

./build.sh bin/enzo-p
Remove bin/enzo-p
2020-08-25 15:02:13 BEGIN
BEGIN Enzo-P/Cello ./build.sh
arch=linux_gnu
prec=double
target=bin/enzo-p
2020-08-25 15:02:13 compiling...                 
('    CELLO_ARCH scons arch=', 'linux_gnu')
('    CELLO_PREC scons prec=', 'double')


scons: warning: Two different environments were specified for target main_enzo.o,
	but they appear to have the same action: $CXX -o $TARGET -c $CXXFLAGS $CCFLAGS $_CCCOMCOM $SOURCES
File "/home/pgrete/src/enzo-e/build/Cello/SConscript", line 210, in <module>
/home/pgrete/src/charm/bin/charmc -language charm++ -o build/Enzo/enzo_EnzoMethodGrackle.o -c -Wall -O3 -g -ffast-math -funroll-loops -fPIC -balancer CommonLBs -DCONFIG_PRECISION_DOUBLE -DSMALL_INTS -DCONFIG_NODE_SIZE=64 -DCONFIG_NODE_SIZE_3=192 -DNO_FREETYPE -DCONFIG_USE_PERFORMANCE -DCONFIG_USE_MEMORY -DCONFIG_NEW_CHARM -DCONFIG_HAVE_VERSION_CONTROL -Iinclude -I/usr/include -I/usr/include/boost -I/lib/x86_64-linux-gnu/include build/Enzo/enzo_EnzoMethodGrackle.cpp
In file included from include/_data.hpp:86,
                 from build/Enzo/enzo.hpp:37,
                 from build/Enzo/enzo_EnzoMethodGrackle.cpp:10:
include/data_FluxData.hpp: In member function ‘int FluxData::index_field(int) const’:
include/data_FluxData.hpp:103:29: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<int>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  103 |     return (0 <= i_f && i_f < field_list_.size()) ?
      |                         ~~~~^~~~~~~~~~~~~~~~~~~~
include/data_FluxData.hpp: In member function ‘const FaceFluxes* FluxData::get_block_fluxes_(int) const’:
include/data_FluxData.hpp:184:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<FaceFluxes*>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  184 |   { return (0 <= i && i < block_fluxes_.size()) ?
      |                       ~~^~~~~~~~~~~~~~~~~~~~~~
include/data_FluxData.hpp: In member function ‘FaceFluxes* FluxData::get_block_fluxes_(int)’:
include/data_FluxData.hpp:187:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<FaceFluxes*>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  187 |   { return (0 <= i && i < block_fluxes_.size()) ?
      |                       ~~^~~~~~~~~~~~~~~~~~~~~~
include/data_FluxData.hpp: In member function ‘const FaceFluxes* FluxData::get_neighbor_fluxes_(int) const’:
include/data_FluxData.hpp:192:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<FaceFluxes*>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  192 |   { return (0 <= i && i < neighbor_fluxes_.size()) ?
      |                       ~~^~~~~~~~~~~~~~~~~~~~~~~~~
include/data_FluxData.hpp: In member function ‘FaceFluxes* FluxData::get_neighbor_fluxes_(int)’:
include/data_FluxData.hpp:195:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<FaceFluxes*>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  195 |   { return (0 <= i && i < neighbor_fluxes_.size()) ?
      |                       ~~^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/_data.hpp:90,
                 from build/Enzo/enzo.hpp:37,
                 from build/Enzo/enzo_EnzoMethodGrackle.cpp:10:
include/data_DataMsg.hpp: In member function ‘void DataMsg::set_num_face_fluxes(int)’:
include/data_DataMsg.hpp:146:11: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<FaceFluxes*>::size_type’ {aka ‘long unsigned int’} [-Wsign-compare]
  146 |     if (i > face_fluxes_list_.size()) {
      |         ~~^~~~~~~~~~~~~~~~~~~~~~~~~~
build/Enzo/enzo_EnzoMethodGrackle.cpp: In constructor ‘EnzoMethodGrackle::EnzoMethodGrackle(double, double)’:
build/Enzo/enzo_EnzoMethodGrackle.cpp:21:5: error: class ‘EnzoMethodGrackle’ does not have any field named ‘grackle_units_’
   21 |     grackle_units_(),
      |     ^~~~~~~~~~~~~~
build/Enzo/enzo_EnzoMethodGrackle.cpp:22:5: error: class ‘EnzoMethodGrackle’ does not have any field named ‘grackle_rates_’
   22 |     grackle_rates_(),
      |     ^~~~~~~~~~~~~~
build/Enzo/enzo_EnzoMethodGrackle.cpp:23:5: error: class ‘EnzoMethodGrackle’ does not have any field named ‘time_grackle_data_initialized_’
   23 |     time_grackle_data_initialized_(ENZO_FLOAT_UNDEFINED)
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build/Enzo/enzo_EnzoMethodGrackle.cpp: In member function ‘virtual double EnzoMethodGrackle::timestep(Block*) const’:
build/Enzo/enzo_EnzoMethodGrackle.cpp:502:22: warning: unused variable ‘config’ [-Wunused-variable]
  502 |   const EnzoConfig * config = enzo::config();
      |                      ^~~~~~
Fatal Error by charmc in directory /home/pgrete/src/enzo-e
   Command g++ -DCMK_GFORTRAN -I/home/pgrete/src/charm/bin/../include -D__CHARMC__=1 -DCONFIG_PRECISION_DOUBLE -DSMALL_INTS -DCONFIG_NODE_SIZE=64 -DCONFIG_NODE_SIZE_3=192 -DNO_FREETYPE -DCONFIG_USE_PERFORMANCE -DCONFIG_USE_MEMORY -DCONFIG_NEW_CHARM -DCONFIG_HAVE_VERSION_CONTROL -Iinclude -I/usr/include -I/usr/include/boost -I/lib/x86_64-linux-gnu/include -Wall -O3 -g -ffast-math -funroll-loops -fPIC -U_FORTIFY_SOURCE -fno-stack-protector -fno-lifetime-dse -c build/Enzo/enzo_EnzoMethodGrackle.cpp -o build/Enzo/enzo_EnzoMethodGrackle.o returned error code 1
charmc exiting...
scons: *** [build/Enzo/enzo_EnzoMethodGrackle.o] Error 1
FAIL
done
END   Enzo-P/Cello ./build.sh: arch = linux_gnu  prec = double  target = bin/enzo-p time = .15 min
make: *** [Makefile:5: bin/enzo-p] Error 1

Am I missing something?

[aemerick]

I'll try and take a look at this today, but its likely there is just an ifdef missing somewhere.

[jobordner]

This affects the enzo-project master branch as well.

[aemerick]

Above PR should take care of this.