Fix simulateError() on Memo component
#2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryqdineen
changed the title
simulateError() on Memo component
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 49 49
Lines 4204 4207 +3
Branches 1130 1130
=======================================
+ Hits 4049 4052 +3
Misses 155 155
Continue to review full report at Codecov.
|
ljharb
approved these changes
Jun 16, 2021
packages/enzyme-test-suite/test/shared/lifecycles/componentDidCatch.jsx
Outdated
Show resolved
Hide resolved
ljharb
force-pushed
the
displayNameOfNode-fix
branch
from
519db6f
to
8c55734
Compare
wojtekmaj
added a commit
to wojtekmaj/enzyme-adapter-react-17
that referenced
this pull request
Nov 4, 2022
From enzymejs/enzyme#2525 Co-Authored-By: Henry Q. Dineen <682132+henryqdineen@users.noreply.github.com>
wojtekmaj
added a commit
to wojtekmaj/enzyme-adapter-react-17
that referenced
this pull request
Nov 4, 2022
From enzymejs/enzyme#2525 Co-Authored-By: Henry Q. Dineen <682132+henryqdineen@users.noreply.github.com>
ljharb
added a commit
that referenced
this pull request
Nov 5, 2022
- [fix] `isEmptyRender`: properly detect memoized SFCs returning null - [fix] avoid a crash with lazy components - [fix] fix `simulateError()` on Memo component (#2525) - [babel] add `babel-plugin-add-module-exports` and fully use ESM syntax - [deps] update `enzyme-shallow-equal`, `enzyme-adapter-utils`, `object.assign`, `object.values`, `prop-types` - [meta] use `npmignore` to autogenerate - [eslint] switch to `@babel/eslint-parser`, fix lintingan npmignore file - [dev deps] update `@babel/cli`, `@babel/core`, `eslint`, `eslint-config-airbnb`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-markdown`, `eslint-plugin-react`, `eslint-plugin-react-hooks` - [dev deps] update `safe-publish-latest`; use `prepublishOnly`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing
TypeError: Cannot read property 'displayNameOfNode' of undefinederrors and I believe I tracked it down to a regression introduced in #2482. ThedisplayNameOfNode()method now referencesthisbut withsimulateError()it ends up being called unbound. My fix is to just always bindadapter.displayNameOfNodesothisis alwaysadapter.Thanks!