Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentinel2Mapper unique_id_attribute error #13

Closed
m-i-g-u-e-l opened this issue Nov 16, 2022 · 2 comments · Fixed by #32
Closed

Sentinel2Mapper unique_id_attribute error #13

m-i-g-u-e-l opened this issue Nov 16, 2022 · 2 comments · Fixed by #32
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@m-i-g-u-e-l
Copy link

If unique_id_attribute = 'id' points to field of type 'string', everything works as expected.

If unique_id_attribute = 'id' points to field of type 'int', following example happens:

Example:

get a new mapper instance

mapper = Sentinel2Mapper(
date_start=date_start,
date_end=date_end,
processing_level=processing_level,
cloud_cover_threshold=scene_cloud_cover_threshold,
mapper_configs=mapper_configs,
feature_collection=aoi,
unique_id_attribute = 'id'
)

File "/home/miguel/code/eodal_fork/eodal/eodal/operational/mapping/sentinel2.py", line 428, in get_complete_timeseries
if isinstance(res, gpd.GeoDataFrame):

UnboundLocalError: local variable 'res' referenced before assignment

@lukasValentin
Copy link
Collaborator

I suggest to make this issue part of the "next generation of the Mapper class" (see #10 )

@lukasValentin lukasValentin added the bug Something isn't working label Nov 16, 2022
@lukasValentin lukasValentin added the wontfix This will not be worked on label Dec 7, 2022
@lukasValentin
Copy link
Collaborator

lukasValentin commented Dec 7, 2022

added the wontfix label since the mapper class will undergo substantial reworking (targeted for EOdal version 0.3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants