Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module override for circl breaks downstream users #149

Closed
Tracked by #86
aaronmondal opened this issue May 24, 2023 · 0 comments · Fixed by #156
Closed
Tracked by #86

Module override for circl breaks downstream users #149

aaronmondal opened this issue May 24, 2023 · 0 comments · Fixed by #156
Assignees
@aaronmondal
Labels
bug Something isn't working

Comments

@aaronmondal
Copy link
Contributor

We can't use go_deps.module_override in upstream dependencies. This means that importers of rules_ll will break. Circl is required for our cluster setup and needs to be usable from downstream repos.
@aaronmondal aaronmondal mentioned this issue May 24, 2023
Open
6 tasks
@aaronmondal aaronmondal changed the title Module override for cirl break downstream users Module override for circl break downstream users May 25, 2023
@aaronmondal aaronmondal changed the title Module override for circl break downstream users Module override for circl breaks downstream users May 25, 2023
@aaronmondal aaronmondal mentioned this issue May 25, 2023
Closed
@aaronmondal aaronmondal self-assigned this May 27, 2023
@aaronmondal aaronmondal added the bug Something isn't working label May 27, 2023
@aaronmondal aaronmondal mentioned this issue Jun 2, 2023
Merged
@aaronmondal aaronmondal linked a pull request Jun 2, 2023 that will close this issue
🎨 Rework circl dependency #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronmondal aaronmondal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🎨 Rework circl dependency aaronmondal/rules_ll
1 participant
@aaronmondal