Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CO] Change of ROOT_DIR #79

Closed
SebGue opened this issue Feb 21, 2020 · 2 comments · Fixed by #90
Closed

[CO] Change of ROOT_DIR #79

SebGue opened this issue Feb 21, 2020 · 2 comments · Fixed by #90

Comments

@SebGue
Copy link
Collaborator

SebGue commented Feb 21, 2020

Hello Pierre,

what do you think about a change of the "root_dir" of pyleecan to ..\XYZ\pyleecan instead of ..\XYZ ?
Therefore all imports have to be corrected, but on the otherhand its enable the user to rename the pyleecan folder without breaking the program.

Best regards, Sebastian

@BonneelP
Copy link
Collaborator

Hello Sebastian,

Indeed that would be handy to be be able to rename the main pyleecan folder (on our side its already creating some confusion!). Maybe we can extend this thought about how pyleecan can be imported in another software. For instance, how should we organized the import if one day we go to pip ?

Best regards,
Pierre

@CedMrnl
Copy link
Contributor

CedMrnl commented Apr 8, 2020

Hello Sebastian, hello Pierre,

First of all, it could be great that users can install Pyleecan with pip. To do so, I think that we would need to reorganize the repository by moving the code into a pyleecan folder and to let general file such that README, LICENSE, and requirements at the root. We would also need to write some setup files as explained in this tutorial. To be able to run the GUI, we would need to add a __main__.py file to parse a command :

python -m pyleecan run_GUI 

What do you thing about it ?

To be able to rename pyleecan folder, I think that we could try to switch from absolute to relative imports, I can try to do it soon.

Best regards,
Cédric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants