Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Attachments] Need to add "No data" and "No results found" labels on attachments screens #1333

Closed
1 task done
VolhaBazhkova opened this issue Apr 30, 2024 · 2 comments
Closed
1 task done

[Attachments] Need to add "No data" and "No results found" labels on attachments screens #1333

VolhaBazhkova opened this issue Apr 30, 2024 · 2 comments
Assignees
@Derikyan @VolhaBazhkova
Labels
bug Something isn't working

Comments

@VolhaBazhkova
Copy link

EPAM AI DIAL chat version

0.10.0

What happened?

  1. By new user click on Clip icon on conversation panel -> note that there is no any attachments/folder (ok), but there is no "No data" label -> bug1
    image

  2. Type any search_word and note that there is no "No results found" -> bug2
    image

Note: be sure to update Manage attachments, Attach files, Select folder

Expected: "No data" and "No results found" labels on all attachment screens
image
image

Confidential information

  • I confirm that do not share any confidential information
@VolhaBazhkova VolhaBazhkova added the bug Something isn't working label Apr 30, 2024
@VolhaBazhkova VolhaBazhkova mentioned this issue May 7, 2024
Open
1 task
@Derikyan Derikyan self-assigned this May 24, 2024
Derikyan added a commit that referenced this issue May 27, 2024
@Derikyan
fix(chat): add 'no results found' and 'no data' for 'manage attachmen…
d99c6c5 
…ts' (Issue #1333)
Derikyan added a commit that referenced this issue May 29, 2024
@Derikyan
fix(chat): add 'no results found' and 'no data' for 'manage attachmen…
5861ad7 
…ts' (Issue #1333)
@Derikyan Derikyan mentioned this issue May 29, 2024
Merged
4 tasks
Derikyan added a commit that referenced this issue May 29, 2024
@Derikyan
fix(chat): add 'no results found' and 'no data' for 'manage attachmen…
883d30a 
…ts' (Issue #1333) (#1452)
@VolhaBazhkova VolhaBazhkova self-assigned this May 30, 2024
@VolhaBazhkova
Copy link
Author

Return the ticket to @Derikyan Need to complete the fix:

  1. "No data" and "No results found" should be centered (in the middle of the modal window).
    Now it's at the top -> bug
    image
  2. "Select folder" window there is always "No result found" label (bug), but should be "No data" when the is no any folder created
    image

@Derikyan Derikyan mentioned this issue May 31, 2024
Merged
4 tasks
Derikyan added a commit that referenced this issue May 31, 2024
@Derikyan
fix(chat): center the 'no data' and 'no result found' and add same lo…
c4d1f5d 
…gic to 'select folders' (Issue #1333) (#1472)
@VolhaBazhkova
Copy link
Author

Verified on staging env successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Derikyan Derikyan

@VolhaBazhkova VolhaBazhkova

Labels
bug Something isn't working
Projects
AI DIAL
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Derikyan @VolhaBazhkova