Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in release 1.1.0 on Vertex env - 404 on 'GET /download/thumbnail' in 'assets' #91

Closed
spiridonovfed opened this issue Dec 15, 2022 · 5 comments
Assignees
Labels
bug Something isn't working priority

Comments

@spiridonovfed
Copy link
Collaborator

Logs:
14-Dec-22 19:23:18 - [ERROR] - src.utils.minio_utils - (minio_utils.py).remake_thumbnail(111) - File is not an image
INFO: 100.120.37.66:53972 - "GET /download/thumbnail?file_id=8 HTTP/1.1" 404 Not Found
INFO: 100.120.37.66:50964 - "POST /files/search HTTP/1.1" 200 OK
INFO: 100.120.37.66:50964 - "POST /datasets/search HTTP/1.1" 200 OK
INFO: 100.120.37.66:50970 - "POST /files/search HTTP/1.1" 200 OK
14-Dec-22 19:23:26 - [ERROR] - src.utils.minio_utils - (minio_utils.py).remake_thumbnail(111) - File is not an image
INFO: 100.120.37.66:50986 - "GET /download/thumbnail?file_id=8 HTTP/1.1" 404 Not Found
INFO: 100.120.37.66:51004 - "GET /download/thumbnail?file_id=7 HTTP/1.1" 200 OK

@spiridonovfed spiridonovfed added bug Something isn't working priority labels Dec 15, 2022
@spiridonovfed spiridonovfed changed the title Bug in release 1.1.0 on Vertex env - 404 on 'GET /download/thumbnail' in 'assets' Bug in release 1.1.0 on Vertex env - 404 on 'GET /download/thumbnail' in 'assets' and ERROR in (minio_utils.py).remake_thumbnail(111) Dec 15, 2022
@spiridonovfed spiridonovfed changed the title Bug in release 1.1.0 on Vertex env - 404 on 'GET /download/thumbnail' in 'assets' and ERROR in (minio_utils.py).remake_thumbnail(111) Bug in release 1.1.0 on Vertex env - 404 on 'GET /download/thumbnail' in 'assets' Dec 15, 2022
@spiridonovfed spiridonovfed self-assigned this Dec 15, 2022
@spiridonovfed
Copy link
Collaborator Author

Logs with extensive logging:

MicrosoftTeams-image (1)

@spiridonovfed
Copy link
Collaborator Author

The root of the problem is this:
We allow to upload file with 'csv' extension.
The function 'minio_utils.remake_thumbnail' tries to create a thumbnail of 'csv' file and breaks there.
This function can only work with pdf-files and images now

@spiridonovfed
Copy link
Collaborator Author

We should fix converting to pdf functionality.
BadgerDoc cannot work with non-pdfs, so csv-file should be converted to pdf automatically

@spiridonovfed
Copy link
Collaborator Author

PR: #99

@spiridonovfed
Copy link
Collaborator Author

PR merged (#99)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

1 participant