Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: We shouldn't allow to export canvas with nucleotides with no natural analog to Sequence format (and FASTA) #2035

Closed
AlexeyGirin opened this issue Jun 28, 2024 · 3 comments · Fixed by #2103 or #2104
Assignees
Labels
Bug Export to Sequence Bucket: Bugs related to Export to Sequence mode Priority: High

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 28, 2024

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode

  2. Open RNA tab - Nucleotides section

  3. Put 5NitInd nucleotide from the library on the canvas
    image

  4. Save canvas to Sequence format (or FASTA)

Actual behavior
System let user to do that
Sequence:
image
FASTA:
image

Expected behavior
Since we don't support import of monomers with no natural analog (as per #1466 and #1755) - we should not allow to export it.
System should throw proper error in that case

Versions

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - epam/ketcher#4382

@AlexeyGirin AlexeyGirin added Bug Priority: High Export to Sequence Bucket: Bugs related to Export to Sequence mode labels Jun 28, 2024
@AlexeyGirin AlexeyGirin added this to the Indigo-1.22.0-rc.1 milestone Jun 28, 2024
@AlexeyGirin AlexeyGirin changed the title Preview: We shouldn't allow to export canvas with nucleotides with no natural analog to Sequence format Preview: We shouldn't allow to export canvas with nucleotides with no natural analog to Sequence format (and FASTA) Jun 28, 2024
@even1024 even1024 self-assigned this Jul 2, 2024
@AlexeyGirin
Copy link
Collaborator Author

We decide to return Error in such case
(by @AlexanderSavelyev and @vanoprenko )

@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.
2024-07-16_14h04_05

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.3]
Indigo version
[Version 1.22.0-rc.3]

@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-14; 20:34:10
  • Indigo Toolkit Version 1.22.0-rc.3.0-gbb5c51fc2-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment