Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox driver is not loaded by default - Dmitry Dobrolubov #59

Closed
MikeShysh opened this issue Mar 10, 2017 · 1 comment
Closed

firefox driver is not loaded by default - Dmitry Dobrolubov #59

MikeShysh opened this issue Mar 10, 2017 · 1 comment

Comments

@MikeShysh
Copy link

Hello,

Version: com.epam.jdi:jdi-uitest-web:1.0.58

STR:

  1. Open main example from https://github.com/epam/JDI-Examples/archive/master.zip
  2. modify test.properties
driver=firefox
driver.getLatest=true
  1. Run tests

Actual result:

[ThreadID: 10]Can't get driver; Thread: 10
Drivers: FIREFOX:com.epam.jdi.uitests.web.selenium.driver.SeleniumDriverFactory$$Lambda$8/1859039536@53f282db; Run: java.lang.ThreadLocal@29b13258Exception: The driver executable does not exist: /home/mike/Downloads/JDI-Examples-master/src/main/resources/driver/geckodriver.exe
[ThreadID: 1]Test run finished. 

Expected result: gecko driver should be loaded and tests successfully started

Going through the sources, I notified that gecko driver is not being loaded at all. Also, the following thing is strange:

from SeleniumDriverFactory:
...
    // GET DRIVER
    protected String registerLocalDriver(DriverTypes driverType) {
        switch (driverType) {
            case CHROME:
            ...
            case FIREFOX:
                return registerDriver(driverType,
                        () -> {
                            DesiredCapabilities capabilities = internetExplorer(); <<<<
                            capabilities.setCapability(PAGE_LOAD_STRATEGY, pageLoadStrategy);
                            setProperty("webdriver.gecko.driver", getFirefoxDriverPath(driversPath));
                            return webDriverSettings.apply(new FirefoxDriver(capabilities));
                        });
            case IE:
...

Please check and fix

@RomanIovlev RomanIovlev changed the title firefox driver is not loaded by default firefox driver is not loaded by default - Dmitry Dobrolubov Jun 7, 2017
@RomanIovlev
Copy link
Collaborator

Will be fixed in #82

RomanIovlev pushed a commit that referenced this issue Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants