Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% formatting ignored when generating CSV #28

Closed
Gagravarr opened this issue May 10, 2018 · 5 comments
Closed

% formatting ignored when generating CSV #28

Gagravarr opened this issue May 10, 2018 · 5 comments

Comments

@Gagravarr
Copy link

For a column that's percent formatted, eg with something like:

format pctdone percent8.0;
format pctincr percent7.1;

If you convert it with CSVDataWriter you get the raw number like 0.6 or 0.833333333333333 rather than the formatted values like 60% or 83.3%

In this small test sas7bdat file, the percentage formats are applied to the 4th and 5th columns (pctdone and pctincr). SAS Viewer screenshot of the expected values below.

sas-viewer

@Yana-Guseva
Copy link
Collaborator

@Gagravarr Hi, we will fix the formatting of percentage values in the next Parso version. Thank you for the test file. Tell me please, can we use this file for Parso tests in the future?

@Gagravarr
Copy link
Author

Yup, it was specifically created for testing, please feel free to use as you wish / as helps!

@Yana-Guseva
Copy link
Collaborator

Thanks!

@printsev
Copy link
Contributor

printsev commented Aug 1, 2018

Was resolved in the recent commit (unfortunately I messed up with issue numbers and put 23 instead of 28).

@printsev printsev closed this as completed Aug 1, 2018
@Gagravarr
Copy link
Author

I've just tried with Apache Tika and a build from github head, and I can confirm the % values are extracting as expected, thanks!

Once there's a new release, I'll bump the Tika dependency to take advantage of the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants