Avoid fetching GImPlot multiple times when possible. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case this is a thread_local variable it is best to avoid fetching too many times. Either way local caching tends to be beneficial as a non-local variable would often be fetched multiple times.
azonenberg
pushed a commit
to ngscopeclient/implot
that referenced
this pull request
Aug 16, 2023
In the case this is a thread_local variable it is best to avoid fetching too many times. Either way local caching tends to be beneficial as a non-local variable would often be fetched multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally speaking, most non-local variables would be fetched again as the compiler needs to be conservative with any non-inline calls. So caching is desirable.
But this is particularly designed around the case of
GImPlotbeing re-defined to be a thread_local variable, in which case the fetches triggers a little more platform-dependent machinery.(PS: Aside from this, I would like to work on a mechanism for dear imgui to allow storing per-extension context pointers inside the main dear imgui context. I'll let you know if that happens.)