Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip button in coach body view #265

Closed
nickbit opened this issue Dec 20, 2021 · 4 comments
Closed

Skip button in coach body view #265

nickbit opened this issue Dec 20, 2021 · 4 comments

Comments

@nickbit
Copy link

nickbit commented Dec 20, 2021

Is your feature request related to a problem? Please describe.

I have a design where the skip button is in the body view of the coach marks.
However, when the skip button is clicked, I cannot call coachMarksController.stop(immediately: true) with an additional isSkipped argument, so the CoachMarksControllerDelegate gets always false in func coachMarksController(_ coachMarksController: CoachMarksController, didEndShowingBySkipping skipped: Bool)

Describe the solution you'd like

Is it possible to enhance the stop function with an additional isSkipped argument for such cases?
Or is there any other workaround in the library?

Describe alternatives you've considered

I can temporarily solve the problem with an isSkipped variable in the view controller classes.

@ephread
Copy link
Owner

ephread commented Dec 22, 2021

Hey @nickbit, thanks for opening a feature request!

Or is there any other workaround in the library?

I can't think of any other than what you've already suggested.

Is it possible to enhance the stop function with an additional isSkipped argument for such cases?

Yup, I think that would make sense. I'll try do do that before the end of the week.

@nickbit
Copy link
Author

nickbit commented Dec 22, 2021

Thank you so much Frédéric!

@nickbit
Copy link
Author

nickbit commented Feb 14, 2022

@ephread any update on that?

@ephread
Copy link
Owner

ephread commented May 25, 2022

@nickbit yes, sorry I haven't been around for the last six months or so. However, a new parameter in stop(immediately:emulatingSkip) should let you emulate a skip. Let me know if it solves your issue!

I have a few other things to add, and I'll create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants