Prefer type inference from options#getFreshValue over reporter #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orter this fixes an issue where the `unknown` Value type of some reporters has been infered by cachified thereby ignoring the much more useful return type of `getFreshValue` fix #70 BREAKING CHANGE: `CachifiedOptions#reporter` has been removed in favor of passing a reporter as second argument to cachified MIGRATION: Change `cachified({ reporter: myReporter /* ... */ })` to `cachified({ /* ... */ }, myReporter)`
Xiphe
commented
Feb 5, 2024
| @@ -57,7 +57,6 @@ export async function getCachedValue<Value>( | |||
| report({ name: 'refreshValueStart' }); | |||
| void cachified({ | |||
| ...context, | |||
| reporter: () => () => {}, | |||
There was a problem hiding this comment.
This existed to silence reporting for background refreshes. Not needed anymore since reporter isn't part of context anymore.
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the
unknownValue type of some reporters has been infered by cachified thereby ignoring the much more useful return type ofgetFreshValuefix #70
BREAKING CHANGE:
CachifiedOptions#reporterhas been removed in favor of passing a reporter as second argument to cachifiedMIGRATION:
Change
cachified({ reporter: myReporter /* ... */ })tocachified({ /* ... */ }, myReporter)