-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout option #56
Comments
To give visibility of processes being killed this needs a mechanism to return the identity of any failures |
good news! Rstan does indeed seem to be killed and die. @seabbs do you have any feeling about how we should represent No Data Available / timeout in the estimate summary? I think the regional epinow route is using the |
That is great news and yes I can imagine. So at the moment, the expectation is that when read in from the out object subregions that have failed will have Line 54 in fafb618
Line 113 in fafb618
NULL in the output indicates any failure.
Could continue this for subregions that have been timed out with an informative log entry or add a message to the out object/into the results folder but this would then add a bit of a headache for results processing. When saving it would make sense to save a killed due to time-out flag definitely. When outputting results (we stick with this duality, by the way, to stay being CRAN compliant + acting like a normal package whilst also supporting saving to folders in order to make producing regional results more independent) we could add another list entry on the top level to the Sorry - a bit of ramble - happy to clarify any of the above that is unclear. |
I have only put the timeout in the regional_epinow function which always returns a result set from the epinow call - this might mean we can sidestep the re-loading from disk issue. |
Sorry yes, I missed that before. Done |
Provide a (crude) mechanism for ending individual location processing after a timeout.
https://www.rdocumentation.org/packages/R.utils/versions/2.9.2/topics/withTimeout
Note (re: stan code keeping running):
"More precisely, if a function is implemented in native code (e.g. C) and the developer of that function does not check for user interrupts, then you cannot interrupt that function neither via a user interrupt (e.g. Ctrl-C) nor via the built-in time out mechanism. To change this, you need to contact the developer of that piece of code and ask them to check for R user interrupts in their native code."
I have found reference to Rstan checking for interrupts every iteration so we'll have to see what happens.
The text was updated successfully, but these errors were encountered: