Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I56 timeout #63

Merged
merged 53 commits into from
Sep 3, 2020
Merged

I56 timeout #63

merged 53 commits into from
Sep 3, 2020

Conversation

joeHickson
Copy link
Collaborator

@joeHickson joeHickson commented Sep 1, 2020

closes #56

  • reset return_timings and max_execution_time defaults once testing is complete

joeHickson and others added 30 commits August 25, 2020 15:27
@seabbs
Copy link
Contributor

seabbs commented Sep 2, 2020

Could you please also increment the package version in the DESCRIPTION to 1.2.0 and add this feature to a new news section in NEWS.md. 1.1.0 just hit CRAN so need to make it clear this feature is not in that version.

@seabbs
Copy link
Contributor

seabbs commented Sep 2, 2020

Thanks looks really great - this will be a great help! Just waiting for CI and then will merge.

@joeHickson
Copy link
Collaborator Author

I'm just waiting on a final run of canada to complete too

@joeHickson
Copy link
Collaborator Author

That failed, I'll need to look at it tomorrow. I'll revert to draft whilst I investigate.

@joeHickson joeHickson marked this pull request as draft September 2, 2020 14:59
@seabbs
Copy link
Contributor

seabbs commented Sep 2, 2020

I see region_timings -> region_timing needing to be updated in the docs.

@joeHickson
Copy link
Collaborator Author

I see region_timings -> region_timing needing to be updated in the docs.
you caught me mid-push!

@codecov-commenter
Copy link

Codecov Report

Merging #63 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #63      +/-   ##
=========================================
- Coverage    2.01%   2.00%   -0.02%     
=========================================
  Files          20      20              
  Lines        3765    3788      +23     
=========================================
  Hits           76      76              
- Misses       3689    3712      +23     
Impacted Files Coverage Δ
R/epinow.R 0.00% <0.00%> (ø)
R/summarise.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e18a3...28d443f. Read the comment docs.

@joeHickson
Copy link
Collaborator Author

package check is failing because episoon is not available on the windows build. @seabbs any ideas?

@seabbs
Copy link
Contributor

seabbs commented Sep 3, 2020

None. That is one of our dev packages but there should be no recent changes to it. If it is just a windows failure I am happy to push to master as is. EpiSoon is only used as a suggest and in none of the core functionality.

@seabbs
Copy link
Contributor

seabbs commented Sep 3, 2020

It looks like the issue is with a failure to install the vctrs 📦 . I think that is a dependency of a dependency and likely due to a CRAN update from the developers....

@joeHickson joeHickson marked this pull request as ready for review September 3, 2020 11:43
@seabbs
Copy link
Contributor

seabbs commented Sep 3, 2020

Yup looks like recently pushed to CRAN: https://cran.r-project.org/web/packages/vctrs/index.html

@joeHickson
Copy link
Collaborator Author

Annoying that windows is the only one affected.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. GitHub docs action is a great idea. Thanks for adding this.

@seabbs seabbs merged commit a3554f9 into master Sep 3, 2020
@seabbs seabbs deleted the i56_timeout branch September 3, 2020 11:46
@seabbs seabbs mentioned this pull request Sep 16, 2020
sbfnk pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout option
4 participants