Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate update_secondary_args #566

Closed
sbfnk opened this issue Feb 21, 2024 · 2 comments
Closed

deprecate update_secondary_args #566

sbfnk opened this issue Feb 21, 2024 · 2 comments
Labels
question Further information is requested

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Feb 21, 2024

I'm unclear on the precise use case for update_secondary_args() which doesn't feature in any of the example work flows. Perhaps it would be good to think about making it simpler for users to pass model fits as priors to others but using this function requires interaction with create_stan_data() which is more of an internal funtion.

Should it be deprecated, and an issue be opened for the broader question of passing previous estimates as priors?

@sbfnk sbfnk added the question Further information is requested label Feb 21, 2024
@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 29, 2024

Turns out this is being used by estimate_secondary so a better strategy might be to make this internal only.

@sbfnk
Copy link
Contributor Author

sbfnk commented Mar 4, 2024

Closing in favour of broader #593

@sbfnk sbfnk closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant