Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glyphs file doesn't actually import (crash) #29

Closed
robey opened this issue Mar 20, 2023 · 3 comments
Closed

glyphs file doesn't actually import (crash) #29

robey opened this issue Mar 20, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@robey
Copy link

robey commented Mar 20, 2023

looks like it can't quite handle glyphs files yet, tho i'd be VERY excited if you ever get that to work!

> ./target/release/gerb
This Glyphs source was generated with an outdated version of Glyphs. The resulting UFOs may be incorrect.
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/glyphs.rs:932:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fish: Job 1, './target/release/gerb' terminated by signal SIGSEGV (Address boundary error)

the "outdated version" comment is incorrect: this file was saved with the most recent glyphs app.

i think it's shelling out to run a python script, and whatever the python script generates (the "ufo" folder?) violates some assumptions gerb is making.

i'll attach the glyphs file in case that's helpful.

@robey robey added the bug Something isn't working label Mar 20, 2023
@robey
Copy link
Author

robey commented Mar 20, 2023

Metrickal2fa-Regular.zip

@epilys epilys closed this as completed in e8dc9e0 Mar 20, 2023
@epilys
Copy link
Owner

epilys commented Mar 20, 2023

Thanks for the report :) The problem was a bad assumption in the parsing. (The outdated version message comes from the external python glyphsLib library)

It works for me with your attachment .glyphs with the commit I just pushed, in case the problem remains we can reopen the issue.

@robey
Copy link
Author

robey commented Mar 20, 2023

that works! :D thanks for this, it looks really cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants