Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Links from Epinio Extension for downloading epinio CLI pointing to rancher instead #309

Open
thehejik opened this issue Aug 17, 2023 · 5 comments · Fixed by #318 or #365
Open
Labels
Milestone

Comments

@thehejik
Copy link
Contributor

Probably a follow up issue for #242

When Epinio Extension is incorporated in Rancher (internal qa doc) the links offered after clicking on About link are pointing to non-existing rancher resources on github instead of epinio. Also logo and labels are Rancher and not Epinio there.

The new about link when accessing Epinio as Extension:
image

The non-existing rancher links:
image

@richard-cox
Copy link
Member

this will be a routing issue, and should be addressed the same time as #315

@richard-cox
Copy link
Member

This is most probably the same issue as #315 and due to changes in urls from upstream dashboard (to include a param). Needs retesting once the dust settles from that one

@torchiaf torchiaf moved this from Backlog to To Test in UI Aug 30, 2023
@thehejik
Copy link
Contributor Author

Still seeing "rancher" in the extension (tested by yarn mem-dev):
image_480

@richard-cox
Copy link
Member

This depends on a ui-backend fix, so the ui image would need updating in the epinio install.

It's an embedded one though, and I've added it to #265. I still need to sort out project columns for these

@richard-cox richard-cox moved this from To Test to To Test (Embedded) in UI Aug 31, 2023
@richard-cox richard-cox moved this from Icebox to To Review in Epinio planning Nov 20, 2023
@thehejik
Copy link
Contributor Author

Still not fixed, tested on rancher:v2.8.0-rc3, extension epinio-1.11.0-2 and post epinio:1.11.0-rc1 from main (ui and server patched to latest ones).

image

@richard-cox richard-cox moved this from To Review to In Progress in Epinio planning Nov 20, 2023
@richard-cox richard-cox moved this from To Test (Embedded) to Review in UI Nov 20, 2023
@richard-cox richard-cox added this to the v1.12.0 milestone Nov 20, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in UI Nov 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Epinio planning Nov 27, 2023
@richard-cox richard-cox reopened this Nov 27, 2023
@github-project-automation github-project-automation bot moved this from Done to Next Up in UI Nov 27, 2023
@richard-cox richard-cox moved this from Next Up to To Test (Embedded) in UI Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: To Test (Embedded)
Development

Successfully merging a pull request may close this issue.

2 participants