Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Supply service chart values when editing a service #339

Closed
Tracked by #252
richard-cox opened this issue Sep 5, 2023 · 3 comments · Fixed by #345
Closed
Tracked by #252

[ui] Supply service chart values when editing a service #339

richard-cox opened this issue Sep 5, 2023 · 3 comments · Fixed by #345
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Sep 5, 2023

Edit side of #252

Dependent on now provided ability to edit service chart values - epinio/epinio#2522

@thehejik
Copy link
Contributor

thehejik commented Nov 15, 2023

report #345 (comment)

Two new issues should be opened:

  • Save button always active on Edit service page
  • The service is very often not updated at all (backend?)

@richard-cox
Copy link
Member Author

richard-cox commented Nov 15, 2023

@thehejik

Save button always active on Edit service page

We don't have a pattern for disabling the save button if there are no changes. If something is invalid though it should be.

The service is very often not updated at all (backend?)

@andreas-kupries In #345 (comment) it looks like the fields changed in the epinio service kick off changes to restricted properties in associated kube resources. Is that correct, if so is the test case valid and do we need to document this kind of thing somewhere?

@thehejik
Copy link
Contributor

@richard-cox

Save button always active on Edit service page

We don't have a pattern for disabling the save button if there are no changes. If something is invalid though it should be.

ok, thanks

The service is very often not updated at all (backend?)

...it looks like the fields changed in the epinio service kick off changes to restricted properties in associated kube resources. Is that correct, if so is the test case valid and do we need to document this kind of thing somewhere?

It is fine with "simpler" nginx bitnami service, report here.

The problem with mysql was likely a conflict between E internal values.extraDeploy keys in the mysql service definition and my custom settings (related to storage) - other values like password and port number doesn't collide and the Edit always works for them.

I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants