Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom post-processing #76

Closed
1 task
athowes opened this issue Jun 6, 2024 · 1 comment
Closed
1 task

Custom post-processing #76

athowes opened this issue Jun 6, 2024 · 1 comment
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Jun 6, 2024

Goal

Add model post-processing functions to the epidist package which interface with the S3 refactor (#70)

Context

The epidist package now uses S3 classes by model (only one currently). It now has the capacity to fit models with multiple families as specified in epidist_family.

Required features

  • An extract_samples function
  • An extract_summaries function
  • Plotting functions? Maybe out of scope for this issue
prep_obs <- epidist_prepare(obs, model = "latent_individual")
fit <- epidist(prep_obs)
samples <- extract_samples(fit, ...)
summaries <- extract_summaries(fit, ...)

Probably samples and summaries should be data.frame objects. Unclear exactly what they should contain.

Specifications

  • Remains to fill

Out of scope

  • Remains to fill

Uncertainties

  • Quality of existing brms post-processing options and how much to direct users to rely on them
  • Whether we should make the family attribute into a class
    • Could put classes for obvious things and let everything else go in default?
  • Whether we should support particular families e.g. lognormal and gamma to a greater extent
  • Whether we should restrict choice of family
@athowes athowes self-assigned this Jun 6, 2024
@athowes athowes mentioned this issue Jun 6, 2024
9 tasks
@athowes athowes changed the title Consider classes for custom post-processing Custom post-processing Jun 24, 2024
@athowes athowes added the high Required for next release label Aug 8, 2024
@athowes athowes removed their assignment Aug 8, 2024
@athowes
Copy link
Collaborator Author

athowes commented Aug 8, 2024

I'm removing this issue as no longer relevant. I'll write a new post-processing meta issue.

@athowes athowes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high Required for next release
Projects
None yet
Development

No branches or pull requests

1 participant