-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace group with .group #102
Conversation
Same for old_group and new_group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff, it looks like you've got everything. The only thing that appears to be missing is that the script in inst
that generates the examples needs updating (this is causing the scoring tests to fail at the moment (probably have some more tests using these examples as a way of checking we are reproducing past results as here obviously been helpful).
I quickly added a check function to look for these variables, restyled after merging develop
, and added some tests for the new check function.
Once examples are updated and there is a news item for this PR very happy for this to be merged in.
Codecov Report
@@ Coverage Diff @@
## develop #102 +/- ##
===========================================
+ Coverage 62.57% 63.16% +0.58%
===========================================
Files 12 12
Lines 946 961 +15
===========================================
+ Hits 592 607 +15
Misses 354 354
Continue to review full report at Codecov.
|
This all looks good to me. Happy to see it merged in when you are ready. |
To me as well. Here we go! |
This PR should fix #99 on the develop branch. All group, old_group and new_group variables have been prefixed with a dot.