Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rspec: 3.9.0 → 3.10.0 (minor) #91

Merged
merged 1 commit into from Nov 14, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Nov 6, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rspec (3.9.0 → 3.10.0) · Repo

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ diff-lcs (indirect, 1.3 → 1.4.4) · Repo · Changelog

Release Notes

1.4.4 (from changelog)

  • Fixed an issue reported by Jun Aruga in the Diff::LCS::Ldiff binary text detection. #44

  • Fixed a theoretical issue reported by Jun Aruga in Diff::LCS::Hunk to raise a more useful exception. #43

  • Added documentation that should address custom object issues as reported in #35.

  • Fixed more diff errors, in part reported in #65.

    • The use of Numeric#abs is incorrect in Diff::LCS::Block#diff_size. The diff size must be accurate for correct change placement.

    • When selecting @max_diff_size in Diff::LCS::Hunk, choose it based on block.diff_size.abs.

    • Made a number of changes that will, unfortunately, increase allocations at the cost of being safe with frozen strings.

    • Add some knowledge that when Diff::LCS::Hunk#diff is called, that we are processing the last hunk, so some changes will be made to how the output is generated.

      • old, ed, and reverse_ed formats have no differences.
      • unified format will report \ No newline at end of file given the correct conditions, at most once. Unified range reporting also differs for the last hunk such that the length of the range is reduced by one.
      • context format will report \No newline at end of file given the correct conditions, up to once per "file". Context range reporting also differs for the last hunk such that the end part of the range is reduced by one to a minimum of one.
  • Added a bunch more tests for the cases above, and fixed hunk_spec.rb so that the phrase being compared isn't nonsense French.

  • Updated formatting.

  • Added a Rake task to assist with manual testing on Ruby 1.8.

1.4.3 (from changelog)

  • Fixed several issues with the 1.4 on Rubies older than 2.0. Some of this was providing useful shim functions to Hoe 3.x (which dropped these older Rubies a while ago). Specifically:

    • Removed Array#lazy from a method in Diff::LCS::Hunk.
    • Changed some unit tests to use old-style Symbol-keyed hashes.
    • Changed some unit test helper functions to no longer use keyword parameters, but only a trailing options hash.
    • Made the use of psych dependent on RUBY_VERSION >= 1.9.

    Resolves #63.

1.4.2 (from changelog)

  • Camille Drapier fixed a small issue with RuboCop configuration. #59
  • Applied another fix (and unit test) to fix an issue for the Chef team. #60, #61

1.4.1 (from changelog)

  • Fix an issue where diff sizes could be negative, and they should be. #57, #58

1.4 (from changelog)

  • Ruby versions lower than 2.4 are soft-deprecated and will not be run as part of the CI process any longer.
  • Akinora MUSHA (knu) added the ability for Diff::LCS::Change objects to be implicitly treated arrays. Originally provided as pull request #47, but it introduced a number of test failures as documented in #48, and remediation of Diff::LCS itself was introduced in #49.
  • Resolved #5 with some tests comparing output from system calls to bin/ldiff with some pre-generated output. Resolved #6 with these tests.
  • Resolved a previously undetected bin/ldiff issue with --context output not matching diff --context output.
  • Resolved an issue with later versions of Ruby not working with an OptParse specification of Numeric; this has been changed to Integer.
  • Brandon Fish added truffleruby in #52.
  • Fixed two missing classes as reported in #53.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 34 commits:

↗️ rspec-core (indirect, 3.9.1 → 3.10.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rspec-expectations (indirect, 3.9.1 → 3.10.0) · Repo · Changelog

Release Notes

3.9.2 (from changelog)

Full Changelog

Bug Fixes:

  • Issue a proper ArgumentError when invalid arguments are given to yield_control modifiers such as at_least et al. (Marc-André Lafortune, #1167)
  • Prevent Ruby 2.7 keyword arguments warning from being issued by custom matcher definitions. (Jon Rowe, #1176)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rspec-mocks (indirect, 3.9.1 → 3.10.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rspec-support (indirect, 3.9.2 → 3.10.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot requested a review from epistrephein as a code owner November 6, 2020 14:46
@depfu depfu bot added the dependencies Libraries depended upon label Nov 6, 2020
@epistrephein epistrephein merged commit c8f7307 into master Nov 14, 2020
@epistrephein epistrephein deleted the depfu/update/rspec-3.10.0 branch November 14, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Libraries depended upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant