-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace travis CI with GHA #24
Conversation
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage ? 88.63%
=======================================
Files ? 5
Lines ? 220
Branches ? 0
=======================================
Hits ? 195
Misses ? 25
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for tagging @jamesmbaazam, could you possibly fill out the PR description on top so we can get an overview of the changes in this PR? Happy to review in general tho. |
See example from an old PR on finalsize: epiverse-trace/finalsize#100 |
Done.! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits @jamesmbaazam, looks fine to me barring the badges section in the Readme file.
I assume from looking through them, that the GHA workflows are auto-generated using {usethis}
or copied from the packagetemplate
, and they also look alright to me. I see the checks are passing as well, so overall seems fine.
Would this be a good opportunity to also implement the Readme md
file with an Rmd
file? {usethis}
can help there as well, and this would work well with also adding the render-readme
workflow from packagetemplate
. This will have to be done sometime anyway.
I think fixing the minor issue with the badges would be the necessary final step before merging to main, optionally you could also move to a Readme.Rmd file.
I would also recommend (squash) merging this branch into main
first, and then rebasing the other open PR branches on to main
before we review them.
This has been implemented in the |
Cool stuff. I'll do that. |
This pull request removes all occurrences of Travis and app veyor support, replacing them with GitHub Actions CI workflows. This will resolve #22.