Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis CI with GHA #24

Merged
merged 8 commits into from
Jan 25, 2023
Merged

Replace travis CI with GHA #24

merged 8 commits into from
Jan 25, 2023

Conversation

jamesmbaazam
Copy link
Collaborator

@jamesmbaazam jamesmbaazam commented Jan 25, 2023

This pull request removes all occurrences of Travis and app veyor support, replacing them with GitHub Actions CI workflows. This will resolve #22.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@466896d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   88.63%           
=======================================
  Files           ?        5           
  Lines           ?      220           
  Branches        ?        0           
=======================================
  Hits            ?      195           
  Misses          ?       25           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pratikunterwegs
Copy link

Thanks for tagging @jamesmbaazam, could you possibly fill out the PR description on top so we can get an overview of the changes in this PR? Happy to review in general tho.

@pratikunterwegs
Copy link

Thanks for tagging @jamesmbaazam, could you possibly fill out the PR description on top so we can get an overview of the changes in this PR? Happy to review in general tho.

See example from an old PR on finalsize: epiverse-trace/finalsize#100

@jamesmbaazam
Copy link
Collaborator Author

Done.!

Copy link

@pratikunterwegs pratikunterwegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits @jamesmbaazam, looks fine to me barring the badges section in the Readme file.

I assume from looking through them, that the GHA workflows are auto-generated using {usethis} or copied from the packagetemplate, and they also look alright to me. I see the checks are passing as well, so overall seems fine.

Would this be a good opportunity to also implement the Readme md file with an Rmd file? {usethis} can help there as well, and this would work well with also adding the render-readme workflow from packagetemplate. This will have to be done sometime anyway.

I think fixing the minor issue with the badges would be the necessary final step before merging to main, optionally you could also move to a Readme.Rmd file.

I would also recommend (squash) merging this branch into main first, and then rebasing the other open PR branches on to main before we review them.

README.md Outdated Show resolved Hide resolved
@jamesmbaazam
Copy link
Collaborator Author

Would this be a good opportunity to also implement the Readme md file with an Rmd file?

This has been implemented in the vignette branch, and will be PR'd later.

@jamesmbaazam
Copy link
Collaborator Author

I would also recommend (squash) merging this branch into main first, and then rebasing the other open PR branches on to main before we review them.

Cool stuff. I'll do that.

@jamesmbaazam jamesmbaazam merged commit c46eb56 into main Jan 25, 2023
@jamesmbaazam jamesmbaazam deleted the GHA_setup branch January 27, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace travis support with Github Actions
3 participants