Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery.load for QueryCSS #20

Closed
rsandor opened this issue May 20, 2014 · 0 comments
Closed

Remove jQuery.load for QueryCSS #20

rsandor opened this issue May 20, 2014 · 0 comments

Comments

@rsandor
Copy link
Collaborator

rsandor commented May 20, 2014

The CSS style querying singelton (QueryCSS) currently relies on jQuery's .load method to place the reference element container into the page. While this technically works, it's weird in two ways:

  1. Single page apps can sometimes completely overwrite the inner html of the <body>
  2. If you attempt to use jQuery.load to initialize real-time plots it will sometimes fire off before the reference element container has been placed.

Let's stop using the jQuery load method here and simply check for the containing element every time we make a query that requires it. Note that this performs fine since QueryCSS is caching the results of css lookups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsandor