Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sail dependency #40

Closed
noraj opened this issue Jul 4, 2022 · 5 comments
Closed

Update sail dependency #40

noraj opened this issue Jul 4, 2022 · 5 comments
Labels
wontfix This will not be worked on

Comments

@noraj
Copy link

noraj commented Jul 4, 2022

The image fails at building because PHP binaries are not found:

image
image

docker-compose.yml is using dockerfiles from ./vendor/laravel/sail/runtimes/8.0, reading composer.lock you were using laravel/sail 1.12.12 but the issue is laravel/sail 1.12.12 is using Ubuntu 21.04 (see https://github.com/laravel/sail/blob/v1.12.12/runtimes/8.0/Dockerfile) and Ubuntu 21.04 is deprecated See http://old-releases.ubuntu.com/releases/. However since laravel/sail v1.13.4 they use Ubuntu 21.10 for the 8.0 php flavor and ubuntu 22.04 for the 8.1 php flavor.

So I removed composer.lock and modified composer.json

-"laravel/sail": "^1.0.1",
+"laravel/sail": "^1.15.0",

Now it builds.

@noraj
Copy link
Author

noraj commented Jul 4, 2022

However I had the issue when generating the app key.

image

Update note: this is because I removed composer.lock so when I relaunched composer install with my PHP which is in 8.1 it required this version.

So I modified the docker-compose.yml too.

-            context: ./vendor/laravel/sail/runtimes/8.0
+           context: ./vendor/laravel/sail/runtimes/8.1
            dockerfile: Dockerfile
            args:
                WWWGROUP: '${WWWGROUP}'
-        image: sail-8.0/app
+       image: sail-8.1/app

Another solution would be to only update composer.json then run composer update "laravel/sail" to update the composer.lock only for sail. But since moving to PHP 8.1 works, it's the occasion to move forward.

@stale
Copy link

stale bot commented Jul 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels Jul 26, 2022
@stale
Copy link

stale bot commented Aug 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels Aug 16, 2022
@stale
Copy link

stale bot commented Sep 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 7, 2022
@stale stale bot closed this as completed Sep 15, 2022
@eporsche eporsche added good first issue Good for newcomers and removed wontfix This will not be worked on labels Sep 24, 2022
@eporsche eporsche reopened this Sep 24, 2022
@eporsche eporsche removed the good first issue Good for newcomers label Sep 24, 2022
@stale
Copy link

stale bot commented Oct 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 15, 2022
@stale stale bot closed this as completed Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants