History ICal export refers to ecs.soton in all entries

[jesusbagpuss]

eprints3.4/perl_lib/EPrints/Plugin/Export/HistoryICal.pm

Line 94 in 1dc4695

$r.="UID:history.".$dataobj->get_value( 'historyid' )."\@ecs.soton.ac.uk\n";

should use something like $self->{session}->config( "host" ); (or securehost?)

[drn05r]

Hi John,

If you could try this changeset or apply it as a patch to test that would be useful, as it does not link into anything I can easier make use of to test it works as expected. That said the change is rather simple, so should just work.

Thanks

David Newman

[jesusbagpuss]

Hi David,
I don't actually have a 3.4 instance running. I noticed this on our 3.3 instance - but thought (seeing as it's not a bad issue (I'd put it more at a typo level), it wasn't worth fixing in 3.3!

Cheers,
John

[drn05r]

I am not aware of any code in 3.3. or 3.4 that integrates with this plugin. If you have some code even for 3.3, that does integrate that you could send me it would allow me to properly test my change.

[jesusbagpuss]

If you do a 'history search', there's an option to export the result set as a History iCal. I tried using this today (for the first time ever I think), which is when I spotted it...

To validate this fix, run the above, and the resultant iCal file will contain the hostname, rather than .ecs.soton... (unless you're testing on a report with a host of ecs.soton... :o)

[jesusbagpuss]

NB a visual inspection of your code looks spot-on!

[drn05r]

Obviously, history search! I have tested and it looks good.