Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation signature IDs #57

Open
redlizard opened this issue Feb 10, 2017 · 0 comments
Open

Conversation signature IDs #57

redlizard opened this issue Feb 10, 2017 · 0 comments

Comments

@redlizard
Copy link
Contributor

Currently, chat messages contain a signature over a payload that includes the number of messages sent using that key. This is a simple way to avoid any replay attacks, as replaying an earlier chat message by a user is considered invalid (it has an incorrect message number).

This scheme only applies to chat messages, not conversation messages. As a consequence, conversation messages are vulnerable to replay attacks. The most critical parts of the protocol have data covered by the signature to prevent this, but not all messages do. It's an easy fix to avoid the entire class of problems by adding a similar message-ID field to conversation messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant