Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with ENCRYPTED attribute in FRAME #103

Closed
achaikou opened this issue May 3, 2019 · 1 comment
Closed

Deal with ENCRYPTED attribute in FRAME #103

achaikou opened this issue May 3, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@achaikou
Copy link
Contributor

achaikou commented May 3, 2019

Per 5.7.1 Frame Objects Encrypted attribute is special

  • If attribute is absent (code 000 or just not in the template), we should consider frame data not being encrypted.
    -However, mere presence of this attribute should make record encrypted. It shouldn't matter if value is never explicitly specified, or if count is set to 0, or the value itself is 0/"".

Right now we drop all absent attributes anyway and do not proceed with attribute load if value is None. Hence we don't always process the value to explicitly make it True or False.

Current tests work because we specified encrypted = False by default, not None.
@ErlendHaa ErlendHaa added the bug Something isn't working label Nov 28, 2019
@achaikou achaikou mentioned this issue Dec 13, 2019
Merged
@ErlendHaa
Copy link
Contributor

This got fixed in #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErlendHaa @achaikou