Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potentially unwanted resampling of parameters #5686

Closed
oyvindeide opened this issue Jul 6, 2023 · 0 comments · Fixed by #7158
Closed

Avoid potentially unwanted resampling of parameters #5686

oyvindeide opened this issue Jul 6, 2023 · 0 comments · Fixed by #7158
Assignees

Comments

@oyvindeide
Copy link
Collaborator

EnsembleExperiment has several different use cases:

  1. Running sensitivity analysis, in this mode, the users have external parameters to ert, and ert is mainly used as a workflow manager, sampling of prior may or may not be important
  2. Evaluating prior for assisted history match when not doing e.g ES-MDA, in this context, we would like ert to sample the prior
  3. Evaluating posterior after performing a manually triggered run of the update algorithm, we dont want ert to sample the prior as that would cause it to overwrite the updated parameters

There is no way for the user to toggle which use case they are operating on, and the logic in ert to differentiate is here:

if not prior_context.sim_fs.realizations_initialized(
prior_context.active_realizations

We should make that more explicit, there are multiple ways of doing that, either adding a check box with Sample parameters, or splitting it up in several run models, or perhaps other. This should be coupled with a check if we will overwrite parameters, and a warning if we do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant