open_storage on existing empty directory attempts to migrate and fails

[eivindjahren]

Doing open_storage("/tmp/empty_directory", mode="w") results in

WARNING ert.storage.local_storage:local_storage.py:235 Migrating storage at /tmp/empty_directory failed with Unknown storage version
ERROR ert.storage.local_storage:local_storage.py:357 Migrating storage at /tmp/empty_directory failed with Use 'local_storage_set_ert_config' before retrieving the config

This exposes two failures:

• Attempting to migrate an empty directory will always fail
• One migration assumes config is available which might not always be the case: 'Use 'local_storage_set_ert_config' before retrieving the config

This can be reproduced with

from ert.storage import open_storage


def test_open_storage_failure(tmp_path, caplog):
    with open_storage(tmp_path, mode="w") as f:
        _ = f.create_experiment()
    assert len(caplog.messages) == 0

[kvashchuka]

@pinkwah is this solved now?

[eivindjahren]

This seems to have changed somewhat as of 791fe11, but is still an issue:

WARNING  ert.storage.local_storage:local_storage.py:371 Unknown storage version in '/tmp/tmpd5acm5ei'
ERROR    ert.storage.local_storage:local_storage.py:357 Migrating storage at /tmp/tmpd5acm5ei failed with Use 'local_storage_set_ert_config' before retrieving the config