Flaky test: unit_tests/gui/test_main_window::test_that_run_dialog_can_be_closed_after_used_to_open_plots

[jonathan-eq]

Test is timing out when waiting for run_dialog.done_button to be enabled. The button is enabled when the worker in the QThread is finished, but this is sometimes not done. I am not sure why the thread does not finish, maybe it just needs longer timeout?

            run_dialog = wait_for_child(gui, qtbot, RunDialog)
    
            # Ensure that once the run dialog is opened
            # another simulation cannot be started
            assert not start_simulation.isEnabled()
    
            # Change simulation mode and ensure that
            # another experiment still cannot be started
            for ind in range(simulation_mode.count()):
                simulation_mode.setCurrentIndex(ind)
                assert not start_simulation.isEnabled()
    
            # The user expects to be able to open e.g. the even viewer
            # while the run dialog is open
            assert not run_dialog.isModal()
    
            qtbot.mouseClick(run_dialog.plot_button, Qt.LeftButton)
>           qtbot.waitUntil(run_dialog.done_button.isVisible, timeout=20000)
E           pytestqt.exceptions.TimeoutError: waitUntil timed out in 20000 milliseconds

To reproduce

Run tests in parallell.
I used command pytest -x tests/unit_tests/gui/test_main_window.py -k plot -n 12 --count 50

Environment

• OS: macOS
• ERT/Komodo release: main ERT
• Python version: 3.10
• Remote/HPC execution involved: no

[jonathan-eq]

The run_esmda fixture has a timeout of 200000, but we only have 20000. Maybe increasing this would help?