Inform user about failing wf jobs #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ManInFez
approved these changes
Mar 18, 2019
| if cancelled: | ||
| self.workflowKilled.emit() | ||
| else: | ||
| success = self._workflow_runner.workflowResult() | ||
| report = self._workflow_runner.workflowReport() | ||
| failed_jobs = [k for k, v in report.items() if not v['completed']] | ||
|
|
||
| if not success: |
There was a problem hiding this comment.
would prefer "if success:"
| if cancelled: | ||
| self.workflowKilled.emit() | ||
| else: | ||
| success = self._workflow_runner.workflowResult() | ||
| report = self._workflow_runner.workflowReport() |
There was a problem hiding this comment.
not needed unless success is true
There was a problem hiding this comment.
I've relocated the variables
lars-petter-hauge
force-pushed
the
inform_user_fail_wf_jobs
branch
from
75c71cd
to
2fd0f38
Compare
markusdregi
pushed a commit
that referenced
this pull request
Jun 9, 2021
…ctions Inline stringlist buffer functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Solves #194
Approach
Lists the following jobs that fails from the executed workflow in the dialog window.
I'll see if the stdout and stderr can be written to file as well, but that will be handled in libres.
Depends on