Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phases in simulation model #39

Closed
anders-kiaer opened this issue Apr 24, 2020 · 0 comments · Fixed by #111
Closed

Phases in simulation model #39

anders-kiaer opened this issue Apr 24, 2020 · 0 comments · Fixed by #111
Assignees
Labels
enhancement New feature or request

Comments

@anders-kiaer
Copy link
Collaborator

Original author: @olelod

Currently the phases of the model are extracted from the relative permeability given.

    if self._swof and self._sgof:
        str_runspec_section = "OIL\nWATER\nGAS\n"
    elif self._swof:
        str_runspec_section = "OIL\nWATER\n"
    elif self._sgof:
        str_runspec_section = "OIL\nGAS\n"

    return {
        "RUNSPEC": str_runspec_section,
        "REGIONS": write_grdecl_file(merged_df_satnum, "SATNUM", int_type=True),
        "PROPS": str_props_section,
    }

Should we reverse this and make the user provide which phases are present in the config yaml? This would make it easier to check if the input needed is provided (relperm, contacts etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants